Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add installation script #120

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Chaitanyabsprip
Copy link

Purpose

There should be an easy way to automate installation of gitmux.
#104

Approach

Currently I've in-lined all dependencies from my scripts and found an alternative method of extracting latest version from Github api instead of using jq.

@Chaitanyabsprip
Copy link
Author

I'm not sure how the version argument can be respected when downloading from a package manager. I haven't added choice of version if the package is being installed from a package manager. I would suggest dropping that part of the script and relying only on curl and github api.

@Chaitanyabsprip
Copy link
Author

There needs to be a discussion about what the default installation directory will be. Currently I've kept it as $HOME/.local/bin

Copy link
Owner

@arl arl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how the version argument can be respected when downloading from a package manager. I haven't added choice of version if the package is being installed from a package manager. I would suggest dropping that part of the script and relying only on curl and github api.

I think we should refine and limit the scope of the script. I expect the script to be used by people that wants to automate installation for their dot files, not to install gitmux for any package manager/distro out there.

In that case, the user already knows the os and architecture they need, these should be passed as arguments to the script.

As for the version number, for a first version of the script I'd say we can also pass it as parameter, and refine later.

There needs to be a discussion about what the default installation directory will be. Currently I've kept it as $HOME/.local/bin

I think this should also be passed as parameter to the script.

To sum it up: we should keep it very simple:

  • check that all parameters are passed
  • check that dependency exist (curl or wget, jq)

This should be already helpful for most people.
And it'd be a good base if more features/automation is needed later.

install Outdated Show resolved Hide resolved
install Outdated Show resolved Hide resolved
install Outdated Show resolved Hide resolved
install Outdated Show resolved Hide resolved
install Show resolved Hide resolved
@Chaitanyabsprip
Copy link
Author

I've made the requested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants