added match for default xml and DocBookXml to magic.xml. added Tests #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw, I'm really not sure if I've done this in the correct way, due to lacking documentation |
|
sorry, didn't mean to ignore this. will try to verify and merge soon. |
|
Hello, |
|
Hi,
I'm sorry for the delays. I've not merged anything into the project for a
while and many folks modify their own magic files to support all the
necessary detection. I'll need to go back through some of the pull requests
and see if I can get them all bundled up soon.
Realistically, what I have intended to do and which hasn't yet happened is
a better way to augment the bundled matchers in a much more flexible way.
Honestly, I do not like the state I left the matching configuration in and
have been looking to completely overhaul things to give jmimemagic a much
needed update. Not sure of the demand for these changes, however, so it may
not happen. Until then, I can look at creating a new release with some
matcher additions.
…On Mon, Oct 5, 2020 at 7:00 AM ghazi-ghariani ***@***.***> wrote:
Hello,
Why did you not merge it ?
best regards
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#19 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABXYKRY3PWRGYQYE2M7IPDSJG7QNANCNFSM4ANIFPPA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added low level xml recognition