-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Joss paper update. #66
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samgdotson
added
Comp:Output
This issue has to do with the output component of the code or document. (writing to databases, etc.)
Difficulty:1-Beginner
This issue does not require expert knowledge and may be a good issue for new contributors.
Priority:1-Critical
This is the highest priority (i.e. it is blocking other work or facing a deadline).
Status:5-In Review
This issue has been handled, and the solution is being reviewed. (probably as a PR)
Type:Docs
Is related to API documentation, website content, etc.
labels
Sep 10, 2024
closing because this PR is to the wrong branch! |
Updated the base branch... |
@munkm bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Comp:Output
This issue has to do with the output component of the code or document. (writing to databases, etc.)
Difficulty:1-Beginner
This issue does not require expert knowledge and may be a good issue for new contributors.
Priority:1-Critical
This is the highest priority (i.e. it is blocking other work or facing a deadline).
Status:5-In Review
This issue has been handled, and the solution is being reviewed. (probably as a PR)
Type:Docs
Is related to API documentation, website content, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the JOSS paper submission according to the reviews from @victoraalves and @fredshone which called for additional information about the state of the field. I addressed this by adding a line about two open source frameworks: Calliope and PyPSA. The brevity of the discussion about these two tools is related to the conciseness of JOSS papers. This submission is already over 1000 words and I don't want to exceed this soft limit much further. I also fixed some typos that were missed in the first draft.