Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates installer issues and resolves the pyomo logging error #65

Merged
merged 14 commits into from
Sep 14, 2024

Conversation

samgdotson
Copy link
Collaborator

@samgdotson samgdotson commented Sep 10, 2024

This PR resolves several issues.

  1. Closes New Pyomo version bug? #50 -- For some reason, either the pyomo or logging libraries ignores the logging.setLevel function. I resolved this by following the solution from this stackoverflow.
  2. This PR updates package installation by retiring the setup.py file and adding a pyproject.toml file. The recent NumPy update to 2.0 caused some dependency issues with Pyomo. These issues have apparently been resolved in version 6.8.0 of pyomo. Since the current build works I have not pinned any versions.
  3. Closes Failed tests on Windows (10) #56 by adding windows and macos to the CI build. Along with several versions of Python (3.9-3.12).

This PR also addresses some comments from @fredshone JOSS review:

  • Adding a windows machine to the CI
  • Adding a code coverage test -- it does not however add a badge to the readme because this project does not have codecov enabled and the "free" badge solutions seem extremely hacky. I'm also not keen on manually updating a badge icon. Happy to hear suggestions, though.

Note

Contrary to @fredshone's request in #56, I changed the default solver to cbc for the test suite, instead of having GLPK. The Calliope project had a nice example for installing CBC on a windows machine via GitHub CI. I haven't found an equivalent command line only guide to installing GLPK.

Local Checks

  • Passing tests (yes, with a single numpy deprecation warning -- from a dependent package).
  • Docs build (yes, with a couple of warnings)
  • Examples run successfully

@victoraalves
@fredshone

@samgdotson samgdotson added Comp:Build This issue has to do with the build system of the code/doc (makefiles, cmake, install errors) Difficulty:2-Challenging This issue may be complex or require specialized skills. Priority:1-Critical This is the highest priority (i.e. it is blocking other work or facing a deadline). Status:5-In Review This issue has been handled, and the solution is being reviewed. (probably as a PR) Type:Bug Something is wrong or broken. This issue or PR is related to a bug in code. Type:Docs Is related to API documentation, website content, etc. Type:Feature New feature or feature request labels Sep 10, 2024
@samgdotson samgdotson added this to the JOSS publication -- Osier milestone Sep 10, 2024
@samgdotson samgdotson self-assigned this Sep 10, 2024
Copy link
Contributor

@yardasol yardasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great PR Sam. Glad you resolved all the pyomo issues!

@samgdotson
Copy link
Collaborator Author

Thanks @yardasol! Care to merge?

(Merging was previously blocked by a ruleset waiting for a status update from the "Build and test" job. I'm not entirely sure why it wasn't being triggered, even though all of the checks within that job passed).

@yardasol yardasol merged commit 5431735 into arfc:main Sep 14, 2024
13 checks passed
@samgdotson samgdotson deleted the installer_update branch September 15, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comp:Build This issue has to do with the build system of the code/doc (makefiles, cmake, install errors) Difficulty:2-Challenging This issue may be complex or require specialized skills. Priority:1-Critical This is the highest priority (i.e. it is blocking other work or facing a deadline). Status:5-In Review This issue has been handled, and the solution is being reviewed. (probably as a PR) Type:Bug Something is wrong or broken. This issue or PR is related to a bug in code. Type:Docs Is related to API documentation, website content, etc. Type:Feature New feature or feature request
Projects
None yet
2 participants