-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates installer issues and resolves the pyomo logging error #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great PR Sam. Glad you resolved all the pyomo issues!
Thanks @yardasol! Care to merge? (Merging was previously blocked by a ruleset waiting for a status update from the "Build and test" job. I'm not entirely sure why it wasn't being triggered, even though all of the checks within that job passed). |
This PR resolves several issues.
logging.setLevel
function. I resolved this by following the solution from this stackoverflow.setup.py
file and adding apyproject.toml
file. The recent NumPy update to 2.0 caused some dependency issues with Pyomo. These issues have apparently been resolved in version 6.8.0 of pyomo. Since the current build works I have not pinned any versions.This PR also addresses some comments from @fredshone JOSS review:
Note
Contrary to @fredshone's request in #56, I changed the default solver to cbc for the test suite, instead of having GLPK. The Calliope project had a nice example for installing CBC on a windows machine via GitHub CI. I haven't found an equivalent command line only guide to installing GLPK.
Local Checks
@victoraalves
@fredshone