Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build rate limiter on server instance #340

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

foodjth
Copy link

@foodjth foodjth commented Jul 26, 2024

build rate limiter for per server instance.

@foodjth foodjth force-pushed the feat/optimizeRateLimiter branch 2 times, most recently from 12d4635 to 30d0d5d Compare August 7, 2024 07:47
return;
}
this.qpsPerInstance = replayPlan.getReplaySendMaxQps();
this.singleTasks = replayPlan.getCaseTotalCount() / targetInstances.size();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

假设replayPlan.getCaseTotalCount() = 1001, targetInstances.size = 5
this.singleTasks = 200

最终每个serviceLimiterMap中的每个limiter的tasks都是200,那么只会跑1000个case,是否会出现页面执行数量和真正执行数量不一致的场景?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

singleTasks是作为判断连续失败case占比分母(continueFailedCaseCount/singleTasks)

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 13.26165% with 242 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@d9210c6). Learn more about missing BASE report.

Files Patch % Lines
.../arextest/schedule/service/PlanConsumeService.java 0.00% 116 Missing ⚠️
...chedule/service/ReplayCaseTransmitServiceImpl.java 35.95% 51 Missing and 6 partials ⚠️
...n/java/com/arextest/schedule/bizlog/BizLogger.java 0.00% 17 Missing ⚠️
.../arextest/schedule/model/PlanExecutionContext.java 9.09% 10 Missing ⚠️
...st/schedule/service/AsyncSendCaseTaskRunnable.java 0.00% 8 Missing ⚠️
...t/schedule/beans/ExecutorServiceConfiguration.java 0.00% 6 Missing ⚠️
...est/schedule/sender/impl/AbstractReplaySender.java 0.00% 5 Missing ⚠️
...a/com/arextest/schedule/model/ExecutionStatus.java 0.00% 4 Missing ⚠️
...xecution/impl/DefaultExecutionContextProvider.java 0.00% 4 Missing ⚠️
...schedule/sender/impl/DefaultDubboReplaySender.java 0.00% 4 Missing ⚠️
... and 4 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff           @@
##             main    #340   +/-   ##
======================================
  Coverage        ?   8.13%           
  Complexity      ?     214           
======================================
  Files           ?     220           
  Lines           ?    6588           
  Branches        ?     699           
======================================
  Hits            ?     536           
  Misses          ?    5991           
  Partials        ?      61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Aug 29, 2024

Copy link

sonarcloud bot commented Oct 15, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants