-
-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug enhancements #710
Draft
umbynos
wants to merge
8
commits into
arduino:master
Choose a base branch
from
umbynos:debug-enhancements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Debug enhancements #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbynos
force-pushed
the
debug-enhancements
branch
from
October 12, 2023 17:07
f6b9e0a
to
628e608
Compare
…ard compatibility this way using old cli version with an updated platform should work if the cli is >= 0.35.0 and the platform is old it will work the old way
umbynos
force-pushed
the
debug-enhancements
branch
from
October 13, 2023 10:39
628e608
to
4faf391
Compare
The PR is in draft because I only modified the nano 33 iot board. All the other boards needs to be updated |
umbynos
commented
Oct 13, 2023
Comment on lines
+261
to
+269
nano_33_iot.debug.cortex-debug.custom.postAttachCommands.0=set remote hardware-watchpoint-limit 2 | ||
nano_33_iot.debug.cortex-debug.custom.postAttachCommands.1=monitor reset halt | ||
nano_33_iot.debug.cortex-debug.custom.postAttachCommands.2=monitor gdb_sync | ||
nano_33_iot.debug.cortex-debug.custom.postAttachCommands.3=thb setup | ||
nano_33_iot.debug.cortex-debug.custom.postAttachCommands.4=c | ||
nano_33_iot.debug.cortex-debug.custom.overrideRestartCommands.0=monitor reset halt | ||
nano_33_iot.debug.cortex-debug.custom.overrideRestartCommands.1=monitor gdb_sync | ||
nano_33_iot.debug.cortex-debug.custom.overrideRestartCommands.2=thb setup | ||
nano_33_iot.debug.cortex-debug.custom.overrideRestartCommands.3=c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been added only for demo purposes. For sure needs updating
This comment was marked as outdated.
This comment was marked as outdated.
this way it does not get defined in case the board does not support it
The CLI is able to give this back using `board details` The IDE2 can auto-select the programmer based on the board used
The CLI is able to give this back using `board details` The IDE2 can auto-select the programmer based on the board used
With newer versions of the IDE this was causing problems
Memory usage change @ 556fb8e
Click for full report table
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change we propose aims to:
arduino-cli debug -I -b <board> -P <debugger> <sketch>
)-P
flag)This PR leverages arduino/arduino-cli#2356