Some build rule fixes (fix use of libstdc++ and printf) #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures some C++-specific symbols, such as
`std::_throw_bad_function_call` and probably others, are automatically
included in the link, preventing linker errors when using some standard
c++ library bits (such as `std::function`).
This follows the same change done for SAMD:
arduino/ArduinoCore-samd#276
This define would serve to use the integer-only version of printf rather than the default. In commit 46470a9 (Remove override printf define from cpp receipe), this was removed from the cpp recipe, probably because this define could cause problems in C++ code and because the Due has plenty of memory for this. However, this same override was still present in the c recipe, so this introduced an inconsistency between .c and .cpp files, where they would end up getting different versions of printf. This commit fixes this by also removing the override for .c files.
matthijskooijman
force-pushed
the
build-rule-fixes
branch
from
90e98ea
to
959950f
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are just two minor fixes I noticed when trying a somewhat more complicated sketch using libstdc++ for SAM. One is really a fix, the other is the second half of an earlier fix by @facchinm.