-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tone implementation #108
base: master
Are you sure you want to change the base?
Tone implementation #108
Conversation
Looks solid. Only one thing to consider: Surely the jitter due to the interrupt is flattening the EMV peek. But it will be measureable and might also interfere with some switching regulators operating in the same range. This could be avoided with same or better frequency accuracy, If you decrease the prescaler to /32 and mask out the LSB in cutoff, so that cutoff value is never odd and the low and high times are equal. |
…ted by DesperateProgrammer.
Thanks for pointing that out, I would have never realized! I just got around to fixing that issue, hopefully all's good now. |
Hi, is there anything else I need to do to get this PR accepted? |
@RedRussianBear pray to some elder deity, possibly - this PR has been blocking one issue in my project for half a year now, which is very frustrating. @cmaglie (or anyone else with the permissions) can this merged, or does it require some changes? Thanks. |
Implemented Tone functionality for SAM3X/Due using TC5.