Fixed string::replace doesn't replace multiple occurrences of longer string with shorter one #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
previously requested changes
Aug 30, 2023
Co-authored-by: per1234 <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #200 +/- ##
=======================================
Coverage 95.77% 95.77%
=======================================
Files 13 13
Lines 970 970
=======================================
Hits 929 929
Misses 41 41
☔ View full report in Codecov by Sentry. |
aentinger
approved these changes
Sep 4, 2023
| @@ -652,9 +652,9 @@ void String::replace(const String& find, const String& replace) | |||
| } | |||
| } else if (diff < 0) { | |||
| unsigned int size = len; // compute size needed for result | |||
| diff = 0 - diff; | |||
There was a problem hiding this comment.
Ah, this line hurts 😉 . (Could it not be abs(diff)? However, you did not commit this crime, simply moved the line to the right position 👍 .
PiotrekB416
deleted the
Fix/string-replace-multiple-longer-by-shorter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes
string::replacenot replacing multiple occurrences of longer string with shorter one.I also included unit tests from the issue
This fixes #199