-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Compatibility to ESP32 ESP8266 #150
Open
rseidt
wants to merge
1
commit into
arduino-libraries:master
Choose a base branch
from
rseidt:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added compat for esp32-esp8266 * fixed to compile examples independently from rs485 lib changes * fixed preprocessors * fixed defines --------- Co-authored-by: Robert Seidt <[email protected]>
Memory usage change @ 4b6c7e8
Click for full report table
Click for full report CSV
|
per1234
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
labels
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added compatibility for espressifs esp32 and esp8266
Based on the idea from mostafahk in PR#70 which seems kind of abandoned (last commit 2 years ago)
As the serial configuration enum is defined as int32 on the ESP (instead of int16 or the other platforms), so made the datatype Dynamic.
This code change will enable the ModbusLibrary to compile sucessfully for ESP32 and ESP8266, but in order to work on those platforms the approriate PR in the RS485 Library will alo have to be merged.