Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): fix table sticky-header failure with scrollbar #3170

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

oljc
Copy link
Member

@oljc oljc commented Jun 4, 2024

Types of changes

  • New feature
  • Bug fix
  • Enhancement
  • Component style change
  • Typescript definition change
  • Documentation change
  • Coding style change
  • Refactoring
  • Test cases
  • Continuous integration
  • Breaking change
  • Others

Background and context

Table设置了 scrollbar 虚拟滚动条时吸顶样式被挂在了虚拟滚动条 container 上而非表格头最外层,导致吸顶失效。

Solution

区分div 和 Scrollbar 包裹两种情况下的样式设置

 ⚠️ renderVirtualListBody 函数不知道为什么留下(改造的时候忘记删除了? 🤔),看来一下并未在任何地方使用就移除了。

iShot_2024-06-04_19.50.51.mp4

How is the change tested?

Changelog

Component Changelog(CN) Changelog(EN) Related issues
Table 修复虚拟滚动条开启时 sticky-header 吸顶失效 fix table sticky-header failure with scrollbar Closed #2728, Closed #2411, Closed #1852

Checklist:

  • Test suite passes (npm run test)
  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others
    should be submitted to main branch)

Other information

Copy link

codesandbox bot commented Jun 4, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@flsion flsion added this to the 2.62.2 milestone Jun 7, 2024
@flsion flsion added the 🐛 Bug Something isn't working label Jun 7, 2024
@flsion
Copy link
Member

flsion commented Jun 7, 2024

@oljc renderVirtualListBody 是历史遗留的代码了,这里改造过。

@flsion flsion merged commit 55eff67 into arco-design:main Jun 7, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
2 participants