Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving the alert race condition #96

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

brickpop
Copy link
Contributor

@brickpop brickpop commented Mar 15, 2024

This PR is final

  • Solves the case where dismissing one alert while another was ongoing would provoke a race condition
  • The main change is on context/Alert.tsx. The rest are just a rename to a more sensible term

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jør∂¡ seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@carlosgj94 carlosgj94 merged commit 544b0e2 into main Mar 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants