Fix react-tutorial: typo, navbar reference and improve error handlig #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dling - Add error handling to Ideas context - Add database creation instructions - Fix form submission clearing
stnguyen90
requested changes
Nov 14, 2024
| @@ -56,30 +64,43 @@ export function useIdeas() { | |||
|
|
|||
| export function IdeasProvider(props) { | |||
| const [ideas, setIdeas] = useState([]); | |||
| const [error, setError] = useState(null); | |||
There was a problem hiding this comment.
This error doesn't look like it's used anywhere 🧐
There was a problem hiding this comment.
I added it in case the user wanted to do something with the state (was setting the state in the catch block) but I've removed it now
Comment on lines
12
to
13
| 3. Give it a name (e.g. "ideas-tracker") | ||
| 4. Save the database ID as you'll need it later |
There was a problem hiding this comment.
The collection screenshot has "Ideas Tracker" for the name and "ideas-tracker" for the ID so let's use something similar for the database ID and name.
There was a problem hiding this comment.
Got it. I've clarified the instruction
Co-authored-by: Steven Nguyen <[email protected]>
stnguyen90
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates doc React tutorial
Test Plan
/docs/tutorials/react/step-7