Fix bug "Cannot read property 'blockUntilReporterExits' of undefined" #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Error raised by reporter [...]: TypeError: Cannot read property 'blockUntilReporterExits' of undefined
This reverts commit c4cd1ff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Perhaps I misunderstanding something in the readme, because I feel like most should be running into this (it's a bug on the latest release): when the
optionsin lib/FileApprover.js are undefined, you get an error trying to boot up the reporter:I received the same error with the Visual Studio code reporter.
I do think this change should be there, because earlier in the file it checks if
optionsis undefined.The solution
I pass an empty object if
optionsis undefined. Normally I would write a failing test for this, but I am at work at the moment. I can add that later.