-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade GraphQL to 16 #8997
Upgrade GraphQL to 16 #8997
Conversation
3ec82e7
to
5761a44
Compare
Maybe we can use a type assertion, and see if that lets us not bump the filesize of the client. |
5761a44
to
8716cbc
Compare
@CruseCtrl The tricky thing is trying to support multiple GraphQL versions. The types as enums don’t exist in GraphQL 15, so I’m trying to figure out a way to continue to support multiple version. I also created this issue on the GraphQL.js repository (graphql/graphql-js#3356) |
Ah, I see. In that case I can't think of a better way to solve this than what you've already done |
@brainkim You are probably already aware of this, but I tried checking out this PR, running Aside: mind rebasing after #9004 (just |
@benjamn I’m trying to see if we can get this merged and not have to make as many changes: |
8716cbc
to
42c7bd6
Compare
42c7bd6
to
082d1b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome - thanks @brainkim!
Similar to changes made by @brainkim in apollographql/apollo-client#8997, this commit fixes the React Apollo template application when built with graphql@16, since support for passing positional arguments was removed in graphql/graphql-js#2904.
Similar to changes made by @brainkim in apollographql/apollo-client#8997, this commit fixes the React Apollo template application when built with graphql@16, since support for passing positional arguments was removed in graphql/graphql-js#2904.
Allows for
graphql@16
to be used with Apollo Client.Fixes: