Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix logic of retry in health check #141

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Yiyiyimu
Copy link
Contributor

@Yiyiyimu Yiyiyimu commented Jul 21, 2021

Signed-off-by: yiyiyimu [email protected]

So when error is not due to etcd disconnection (has no healthy etcd endpoint available), it could correctly return error rather than just continue

@Yiyiyimu Yiyiyimu marked this pull request as ready for review July 21, 2021 03:23
@Yiyiyimu
Copy link
Contributor Author

cc @spacewander

@b03jsj
Copy link

b03jsj commented Feb 22, 2023

I found that problem too, I do it by myself.
I also found grpc token is invalid err

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants