Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split test docs and add laravel support #2021

Conversation

vinceAmstoutz
Copy link
Contributor

@vinceAmstoutz vinceAmstoutz commented Oct 1, 2024

As discussed in our messages with @dunglas, I will take the following steps:

  • Create a Documentation File for Laravel: I will create a new document titled laravel/testing.md that describes how to write tests using Pest and PHPUnit in Laravel.
  • Reorganize Symfony Documentation: To improve separation of concerns, I will move the Symfony-related content from core/testing.md into symfony/testing.md.
  • Maintain Core Documentation: The core/testing.md file will remain the central resource for testing documentation encompassing both Symfony and Laravel.

@dunglas
Copy link
Member

dunglas commented Oct 1, 2024

Maybe can you keep the root core/testing.md file, move most of its content in symfony/testing.md directly (no need for two files IMHO), add a new laravel/testing.md file, and reference the Laravel and Symfony testing docs in docs/testing.md.

This will prevent setting redirections.

@vinceAmstoutz
Copy link
Contributor Author

Maybe can you keep the root core/testing.md file, move most of its content in symfony/testing.md directly (no need for two files IMHO), add a new laravel/testing.md file, and reference the Laravel and Symfony testing docs in docs/testing.md.

This will prevent setting redirections.

Indeed, that's better, I'll do that!

@vinceAmstoutz vinceAmstoutz marked this pull request as draft October 3, 2024 10:15
@vinceAmstoutz vinceAmstoutz force-pushed the chore-move-symfony-testing-doc-into-symfony-section branch from 2fdfe7b to b724277 Compare October 22, 2024 15:07
@vinceAmstoutz vinceAmstoutz marked this pull request as ready for review October 22, 2024 15:08
@vinceAmstoutz vinceAmstoutz changed the title Relocated symfony testing doc & update related links Add Laravel testing doc and reorganize old testing docs Oct 22, 2024
@vinceAmstoutz vinceAmstoutz force-pushed the chore-move-symfony-testing-doc-into-symfony-section branch 3 times, most recently from 639740c to b9ef1a1 Compare October 22, 2024 15:39
laravel/testing.md Outdated Show resolved Hide resolved
laravel/testing.md Outdated Show resolved Hide resolved
laravel/testing.md Outdated Show resolved Hide resolved
laravel/testing.md Outdated Show resolved Hide resolved
laravel/testing.md Outdated Show resolved Hide resolved
laravel/testing.md Show resolved Hide resolved
laravel/testing.md Outdated Show resolved Hide resolved
laravel/testing.md Outdated Show resolved Hide resolved
symfony/testing.md Outdated Show resolved Hide resolved
symfony/testing.md Outdated Show resolved Hide resolved
@vinceAmstoutz vinceAmstoutz force-pushed the chore-move-symfony-testing-doc-into-symfony-section branch from bb5af72 to eb1e40f Compare October 23, 2024 15:54
@vinceAmstoutz vinceAmstoutz changed the title Add Laravel testing doc and reorganize old testing docs refactor: split test docs and add laravel support Nov 21, 2024
@vinceAmstoutz vinceAmstoutz force-pushed the chore-move-symfony-testing-doc-into-symfony-section branch from eb1e40f to 327c6d5 Compare November 25, 2024 08:37
@vinceAmstoutz vinceAmstoutz merged commit df0365e into api-platform:4.0 Nov 25, 2024
1 check passed
@vinceAmstoutz vinceAmstoutz deleted the chore-move-symfony-testing-doc-into-symfony-section branch November 25, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants