-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve] change RoutingMode default from UseSinglePartition to RoundRobinDistribution #286
base: main
Are you sure you want to change the base?
[improve] change RoutingMode default from UseSinglePartition to RoundRobinDistribution #286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that we should align the default with the Java client
can you please add a test case ?
This is breaking behaviour change, we should discuss it on the mailing list and we should also take care of not cherry-pick it on maintenance branches, such kind of changes is allowed only on major versions
I agree with @eolivelli. It would be good to fix the inconsistency with the Java client, but it would also bring breaking changes. We should discuss it on the mailing list. |
Have modified the configuration test to verify default config change. It seems not necessary to add additional test because testRoundRobinRoutingPolicy() is included. |
Hi, @TakaHiR07 is there any chance to resolve the conflicts? |
91dddb5
to
6dd859d
Compare
@BewareMyPower done. |
It seems that there are some existing tests that failed due to this change. |
I revert the pr change and this test "testHasMessageAvailableAfterSeekToEnd" still fail. It seems this pr is not the reason |
Motivation
It is more reasonable to set routingMode default RoundRobinDistribution, just as the java client.
Otherwise, user may ignore this config, and producer can not produce msg to all partitions
Modifications
change default routingMode config
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
(Please explain why)
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)