Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-11511. Introduce metrics in deletion services of OM #7377

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Tejaskriya
Copy link
Contributor

@Tejaskriya Tejaskriya commented Oct 30, 2024

What changes were proposed in this pull request?

The following metrics are added in OM's deletingServices:
KeyDeleting
No of keys processed for delete in the current iteration and overall since last restart
No of keys sent to scm for delete and response(success/fail) in the current iteration and overall since last restart
Total time spent in current iteration

DirDeleting
No of dirs/empty dirs processed for delete in the current iteration and overall since last restart
No of subfiles processed for delete in the current iteration and overall since last restart
Total time spent in current iteration

Dirpurge
No of dirs purged since last restart and in the last request
No of subfiles purged since last restart and in the last request

Keypurge
No of keys purged since last restart and in the last request

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-11511

How was this patch tested?

Tested manually in docker at the jmx endpoint http://localhost:9874/jmx?qry=Hadoop:service=OzoneManager,name=DeletingServiceMetrics :

{
  "beans" : [ {
    "name" : "Hadoop:service=OzoneManager,name=DeletingServiceMetrics",
    "modelerType" : "DeletingServiceMetrics",
    "tag.Context" : "ozone",
    "tag.Hostname" : "257dd53cacdf",
    "IterationDirDeleted" : 1,
    "IterationDirDuration" : 18,
    "IterationDirRunCount" : 8,
    "IterationDirStartTime" : 515836,
    "IterationFilesMoved" : 0,
    "IterationKeyDuration" : 53,
    "IterationKeyRunCount" : 9,
    "IterationKeyStartTime" : 575834,
    "IterationKeysDeleteSuccess" : 1,
    "IterationKeysDeletionRequest" : 1,
    "IterationKeysProcessed" : 1,
    "IterationSubDirDeleted" : 5,
    "IterationSubDirsMoved" : 1,
    "NumDirDeleted" : 6,
    "NumDirPurged" : 5,
    "NumDirPurgedInLatestRequest" : 5,
    "NumDirsMoved" : 0,
    "NumFilesMoved" : 1,
    "NumKeysDeleteSuccess" : 1,
    "NumKeysDeletionRequest" : 1,
    "NumKeysProcessed" : 1,
    "NumKeysPurged" : 1,
    "NumKeysPurgedInLatestRequest" : 1,
    "NumSubKeysPurged" : 1,
    "NumSubKeysPurgedInLatestRequest" : 1
  } ]
}

@Tejaskriya Tejaskriya marked this pull request as ready for review November 4, 2024 08:33
@errose28 errose28 self-requested a review November 4, 2024 17:39
@Tejaskriya
Copy link
Contributor Author

@ashishkumar50 thank you for the reviews, I have addressed the comments, could you please review the update?

@Tejaskriya
Copy link
Contributor Author

@ashishkumar50 I have addressed all the comments, thank you for the review.
@errose28 could you please review the patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants