HDDS-11410. Refactoring more tests from TestContainerBalancerTask #7156
+245
−372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tejaskriya, take a look please |
Tejaskriya
reviewed
Sep 5, 2024
| if (nodeCount < DATANODE_COUNT_LIMIT_FOR_SMALL_CLUSTER) { | ||
| config.setMaxDatanodesPercentageToInvolvePerIteration(100); | ||
| } | ||
| config.setThreshold(10); |
There was a problem hiding this comment.
Setting the threshold has been removed here and in few more tests below, but in the newly introduced ContainerBalancerConfigBuilder, we aren't setting it. Is this intentional?
There was a problem hiding this comment.
@Tejaskriya , thank for a review. I forgot about threshold thanks, I'll fix it
|
/pending set threshold in tests |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…terationResultTimeout test
|
@adoroszlai , you mean explicitly write |
|
@Montura no, I only meant that based on this conversation something needs to be done about setting threshold. If you have addressed that, please reply |
|
/ready |
github-actions
bot
dismissed
their stale review
Blocking review request is removed.
Tejaskriya
approved these changes
Nov 19, 2024
|
Looks like this increases test run time from: to: So 2x for The following test cases take more than 1 second: |
There are 3 possible solutions:
|
Can you please explore how much |
- initializeIterationShouldUpdateUnBalancedNodesWhenThresholdChanges (reduce iterations 50 -> 10 - checkIterationResultTimeout (increase maxEnteringSize, reduce timeouts)
|
UPD:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR for HDDS-9889 we discussed with Siddhant Sangwan that tests form
org.apache.hadoop.hdds.scm.container.balancer.TestContainerBalancerTaskcould be refactored usingMockedSCMclass (introduced in HDDS-9889)Some work has been already done in:
What changes were proposed in this pull request?
org.apache.hadoop.hdds.scm.container.balancer.TestContainerBalancerTaskWhat is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11410
How was this patch tested?
Use standalone tests