-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kernel build support for X86_64 #14957
Conversation
arch/x86_64/: fix broken set_cr3() Signed-off-by: p-szafonimateusz <[email protected]>
arch/x86_64: add syscalls support Signed-off-by: p-szafonimateusz <[email protected]>
arch/x86_64/include/intel64/arch.h: align definitions Signed-off-by: p-szafonimateusz <[email protected]>
arch/x86_64: add kernel build support Signed-off-by: p-szafonimateusz <[email protected]>
arch/x86_64: add kernel stack support Signed-off-by: p-szafonimateusz <[email protected]>
arch/x86_64: handle TLB shootdown Signed-off-by: p-szafonimateusz <[email protected]>
[Experimental Bot, please feedback here] No, this PR description does not fully meet the NuttX requirements. While it provides a summary of the changes, it lacks crucial details required for proper review. Here's a breakdown of what's missing and how to improve it: Summary:
Impact:
Testing:
Example of an improved description (for just one of the changes): Summary
Impact
Testing
Testing logs before change:
Testing logs after change:
Repeat this detailed structure for each item listed in the original summary. By providing comprehensive information, you significantly improve the review process and increase the chances of your PR being accepted. |
knsh_romfs - for QEMU and legacy serial port knsh_romfs_pci - for bare-metal Intel hardware and PCI serial port Steps to build kernel image with user-space apps in romfs: $ ./tools/configure.sh qemu-intel64/knsh_romfs $ make -j $ make export -j $ pushd ../apps $ ./tools/mkimport.sh -z -x ../nuttx/nuttx-export-*.tar.gz $ make import -j $ ./tools/mkromfsimg.sh $ mv boot_romfsimg.h ../nuttx/arch/x86_64/src/board/romfs_boot.c $ popd $ make -j Signed-off-by: p-szafonimateusz <[email protected]>
arch/x86_64/intel64_irq.c: remove some magic numbers Signed-off-by: p-szafonimateusz <[email protected]>
3b6bcda
to
54aa7e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include new board profile here: https://nuttx.apache.org/docs/latest/platforms/x86_64/intel64/boards/qemu-intel64/index.html
Documentation: add x86_64 kernel build configs
doc updated |
No shared memory or vmalloc (kmap) support :(? |
maybe later if needed |
remove unnecessary nested syscalls logic, it's already handled different way
6db3098
to
1a08d36
Compare
0e1e79f
to
8233726
Compare
arch/x86_64/intel64: re-enable interrupts before syscall handle
8233726
to
9b8fedf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Impact
kernel build supported for x86_64
Testing
ostest on qemu and bare metal Intel HW