-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develocity integration #1554
base: master
Are you sure you want to change the base?
Develocity integration #1554
Conversation
I don't mind CI build. could be eventually interesting to enable this here https://github.com/apache/maven-gh-actions-shared/ if eventually we want to compare maven versions/jdk for more CI builds |
@olamy, this will only publish local builds if you authenticate with your Apache LDAP credentials on ge.apache.org; unauthenticated publishing is not configured for Apache projects. As for the data - unless you are explicitly printing out all of your env variables or adding them to custom values, those values aren't captured anywhere, even if used as an input to the build (in which case a hash is captured). About https://github.com/apache/maven-gh-actions-shared/ - it is a limitation of gihub actions that shared workflows can't use secrets, unless they're passed in, so unfortunately that can't be directly integrated there as the env var needs to be set up per the "root" workflow. |
68a09a6
to
fd4275e
Compare
Thanks for proposition. First I would like disable such feature at local build at all, we can log into ge.a.o and forgot to logout before build. If we agree that it will be valuable for Maven project build, we can try implements it in shared-gh-actions. I would like to see a discussion on ML about it. |
@slachiewicz, it was nice meeting you at Community over Code today. This PR will enable you to publish Build Scans to ge.apache.org as discussed.
Description
This PR publishes a build scan for every CI build and for every local build from an authenticated Apache committer. The build will not fail if publishing fails. Local and remote caching was left disabled on this PR by design so that the build is not affected by this change.
The build scans of the Apache Maven Core project are published to the Develocity instance at ge.apache.org, hosted by the Apache Software Foundation and run in partnership between the ASF and Gradle. This Develocity instance has all features and extensions enabled and is freely available for use by the Apache Maven Core project and all other Apache projects.
On this Develocity instance, Apache Maven Core will have access not only to all of the published build scans but other aggregate data features such as:
Please let me know if there are any questions about the value of Develocity or the changes in this pull request and I’d be happy to address them.
Checklist
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes. Account creation is in progress
[MNG-XXX] SUMMARY
,where you replace
MNG-XXX
andSUMMARY
with the appropriate JIRA issue.[MNG-XXX] SUMMARY
.Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.
A licensing agreement between ASF and Gradle is already in place, covering the contribution. For more information, reach out to the ASF Infra team.