Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(SystemClock): Added PreciseClock implementation to the system clock class, for the benefit of Java 8 users. #3217

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

jaykataria1111
Copy link

@jaykataria1111 jaykataria1111 commented Nov 19, 2024

Straight forward change to override the behavior of System Clock, to implement the Precise Clock interface, for the benefit of Java 8 users. The PR is for issue #3198

Checklist

  • Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise
  • ./mvnw verify succeeds (if it fails due to code formatting issues reported by Spotless, simply run ./mvnw spotless:apply and retry)
  • Non-trivial changes contain an entry file in the src/changelog/.2.x.x directory
  • Tests for the changes are provided
  • Commits are signed (optional, but highly recommended)

…ock class, for the benefit of Java 8 users.
@jaykataria1111 jaykataria1111 marked this pull request as ready for review November 19, 2024 08:18
Copy link

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 Build Scan PUBLISHED
Generated by gradle/develocity-actions

@ppkarwasz
Copy link
Contributor

The build failure is due to the 2.24.2 release being published (BND checks your code against 2.24.2 now, instead of 2.24.1 before).

Please, rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants