-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kie-issues#208: Renaming any "NamedElement" on the DMN Editor should update all references to the old name #2760
base: main
Are you sure you want to change the base?
Conversation
…update all references to the old name
…update all references to the old name
f04b142
to
de7015e
Compare
|
||
const resetFormData = useCallback(() => { | ||
setExpressionName(selectedExpressionName); | ||
setDataType(selectedDataType); | ||
}, [selectedExpressionName, selectedDataType]); | ||
|
||
// onCancel doens't prevent the onHide call | ||
// onCancel doesn't prevent the onHide call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a typo.
Thank you for the PR @danielzhe. It's going to take me a few days to go over everything with the care it deserves. Will keep you posted! |
@danielzhe Storybook is pointing to code using |
Closes: apache/incubator-kie-issues#208
Some comments about the changes:
Action.VariableChanged
;Renaming Data Types
Data.Types.mp4
Renaming BKMs and parameters
Bkm.and.Parameters.mp4
General rename
Some.Renames.mp4
Renaming Included Models name
It does not show the confirmation dialog, because doesn't make sense to not update the references in this case, since this already was the default behavior before this PR (when we renamed a included model, we already updated all the references except the expressions, now we update the expressions).
Included.Models.mp4