Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#208: Renaming any "NamedElement" on the DMN Editor should update all references to the old name #2760

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

danielzhe
Copy link
Contributor

@danielzhe danielzhe commented Nov 22, 2024

Closes: apache/incubator-kie-issues#208

Some comments about the changes:

  • We are tracking now all changes performed in BEE reported to DMN Editor. For now, we only have "special treatment" for the Action.VariableChanged;
  • A big part of the changes are related to this. Don't panic. It is just an indentation level that can make the PR bigger than it really is;
  • In the lower levels of the code, I refactored from "variable" to "identifier", because those objects are not only variables but identifiers;
  • I added documentation to a few methods and classes.

Renaming Data Types

Data.Types.mp4

Renaming BKMs and parameters

Bkm.and.Parameters.mp4

General rename

Some.Renames.mp4

Renaming Included Models name
It does not show the confirmation dialog, because doesn't make sense to not update the references in this case, since this already was the default behavior before this PR (when we renamed a included model, we already updated all the references except the expressions, now we update the expressions).

Included.Models.mp4

@danielzhe danielzhe marked this pull request as ready for review November 22, 2024 18:41
@danielzhe danielzhe changed the title [WIP] kie-issues#208: Renaming any "NamedElement" on the DMN Editor should update all references to the old name kie-issues#208: Renaming any "NamedElement" on the DMN Editor should update all references to the old name Nov 22, 2024

const resetFormData = useCallback(() => {
setExpressionName(selectedExpressionName);
setDataType(selectedDataType);
}, [selectedExpressionName, selectedDataType]);

// onCancel doens't prevent the onHide call
// onCancel doesn't prevent the onHide call
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo.

@tiagobento
Copy link
Contributor

Thank you for the PR @danielzhe. It's going to take me a few days to go over everything with the care it deserves. Will keep you posted!

@porcelli porcelli self-assigned this Nov 23, 2024
@jomarko jomarko self-requested a review November 25, 2024 09:38
@tiagobento
Copy link
Contributor

@danielzhe Storybook is pointing to code using ../src because it is used during development. The changes you introduced will make the development experience much worse, requiring us to rebuild stuff after a change, if I'm not mistaken... can you please check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming any "NamedElement" on the DMN Editor should update all references to the old name
3 participants