Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kie-issues#2659: [SonataFlow] Migrate DBMigration Image from SonataFlow operator repository to kie-tools #2697

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

kie-issues#2659: [SonataFlow] Migrate DBMigration Image from SonataFlow operator repository to kie-tools #2697

wants to merge 18 commits into from
+1,162 −0

Conversation

rhkp
Copy link
Contributor

@rhkp rhkp commented Oct 22, 2024

Closes #2659
Add kogito-db-migrator-tool and kogito-db-migrator-tool-image packages for use by the SonataFlow Operator.

@rhkp rhkp requested a review from tiagobento as a code owner October 22, 2024 19:16
ricardozanini
ricardozanini requested changes Oct 22, 2024
View reviewed changes
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some comments to adjust the PR. Thank you!

packages/kogito-db-migrator-tool-image/README.md Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool-image/README.md Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool-image/cekit/image.yaml Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool-image/cekit/image.yaml Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool-image/cekit/modules/kogito-postgres-db-migration-deps/install Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/src/main/cekit/image.yaml Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/src/main/cekit/image.yaml Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/src/main/cekit/image.yaml Outdated Show resolved Hide resolved
...ges/kogito-db-migrator-tool/src/main/cekit/modules/kogito-postgres-db-migration-deps/install Outdated Show resolved Hide resolved
...ogito-db-migrator-tool/src/main/cekit/modules/kogito-postgres-db-migration-deps/migration.sh Outdated Show resolved Hide resolved
tiagobento
tiagobento requested changes Oct 22, 2024
View reviewed changes
packages/kogito-db-migrator-tool/env/index.js Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/src/main/cekit/image.yaml Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/install.js Show resolved Hide resolved
packages/kogito-db-migrator-tool/package.json Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/.gitignore Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/get-kogito-ddl-scripts.sh Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/install.js Outdated Show resolved Hide resolved
ricardozanini
ricardozanini requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the same directory structure we already have in the other images: https://github.com/apache/incubator-kie-tools/tree/main/packages/kogito-data-index-ephemeral-image

packages/kogito-db-migrator-tool-image/cekit/image.yaml Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/README.md Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/install.js Show resolved Hide resolved
packages/kogito-db-migrator-tool/pom.xml Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/pom.xml Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool-image/cekit/image.yaml Outdated Show resolved Hide resolved
tiagobento
tiagobento requested changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@tiagobento tiagobento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more inline comments. Thanks for the changes so far @rhkp!

packages/kogito-db-migrator-tool/package.json Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/pom.xml Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/pom.xml Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/.dockerignore Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/.gitignore Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/env/index.js Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/install.js Show resolved Hide resolved
ricardozanini
ricardozanini requested changes Oct 25, 2024
View reviewed changes
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are almost there!

By the way, have you successfully built this image locally using this package?

packages/kogito-db-migrator-tool-image/resources/build-container-image.sh Outdated Show resolved Hide resolved
...ogito-db-migrator-tool-image/resources/modules/kogito-postgres-db-migration-deps/module.yaml Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool-image/resources/kogito-db-migrator-tool-image.yaml Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/pom.xml Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/pom.xml Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/pom.xml Outdated Show resolved Hide resolved
@rhkp
Copy link
Contributor Author

rhkp commented Oct 25, 2024

We are almost there!

By the way, have you successfully built this image locally using this package?

Yes. All build:prod and docker run are successful, locally, as in screenshots.

image
image
image

@tiagobento
Copy link
Contributor

@rhkp Not sure this is WIP, but having these new env vars on root-env is not really the way to go. Can you please share your reasoning? Not sure if there are things missing on MANUAL.md that could help. Thanks!

@rhkp
Copy link
Contributor Author

rhkp commented Oct 29, 2024

@rhkp Not sure this is WIP, but having these new env vars on root-env is not really the way to go. Can you please share your reasoning? Not sure if there are things missing on MANUAL.md that could help. Thanks!

Hi @tiagobento,
We have used a better approach using maven dependency plugin and changes to the root-env are rolled back.

tiagobento
tiagobento requested changes Oct 29, 2024
View reviewed changes
packages/kogito-db-migrator-tool-image/resources/build-container-image.sh Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool-image/resources/kogito-db-migrator-tool-image.yaml Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool-image/resources/kogito-db-migrator-tool-image.yaml Outdated Show resolved Hide resolved
...ogito-db-migrator-tool-image/resources/modules/kogito-postgres-db-migration-deps/module.yaml Show resolved Hide resolved
packages/kogito-db-migrator-tool/README.md Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/package.json Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/package.json Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/package.json Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/build-db-migrator-jar.sh Outdated Show resolved Hide resolved
packages/kogito-db-migrator-tool/README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgdoliveira rgdoliveira rgdoliveira left review comments

@tiagobento tiagobento tiagobento requested changes

@ricardozanini ricardozanini ricardozanini requested changes

@wmedvede wmedvede Awaiting requested review from wmedvede

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area:sonataflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SonataFlow] Migrate DBMigration Image from SonataFlow operator repository to kie-tools
4 participants
@rhkp @tiagobento @ricardozanini @rgdoliveira