Skip to content

Commit

Permalink
PR review
Browse files Browse the repository at this point in the history
  • Loading branch information
tiagobento committed Nov 20, 2024
1 parent d2b124f commit 71a1d57
Show file tree
Hide file tree
Showing 11 changed files with 17 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ export function BpmnEditorClassicPage() {
editorEnvelopeLocator={editorEnvelopeLocator}
file={file}
setFile={setFile}
fileExtension={"dmn"}
accept={".dmn"}
fileExtension={"bpmn"}
accept={".bpmn"}
/>
}
>
Expand Down
2 changes: 1 addition & 1 deletion examples/bpmn-editor-classic-on-webapp/src/Sidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import * as React from "react";
import { EditorEnvelopeLocator } from "@kie-tools-core/editor/dist/api";
import { useCallback, useRef, useState } from "react";
import { Nav, NavItem, NavList } from "@patternfly/react-core/dist/js/components/Nav";
import { Nav, NavList } from "@patternfly/react-core/dist/js/components/Nav";
import { TextInput } from "@patternfly/react-core/dist/js/components/TextInput";
import { EmbeddedEditorRef, useDirtyState } from "@kie-tools-core/editor/dist/embedded";
import { EmbeddedEditorFile } from "@kie-tools-core/editor/dist/channel";
Expand Down
2 changes: 1 addition & 1 deletion examples/dmn-editor-classic-on-webapp/src/Sidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import * as React from "react";
import { EditorEnvelopeLocator } from "@kie-tools-core/editor/dist/api";
import { useCallback, useRef, useState } from "react";
import { Nav, NavItem, NavList } from "@patternfly/react-core/dist/js/components/Nav";
import { Nav, NavList } from "@patternfly/react-core/dist/js/components/Nav";
import { TextInput } from "@patternfly/react-core/dist/js/components/TextInput";
import { EmbeddedEditorRef, useDirtyState } from "@kie-tools-core/editor/dist/embedded";
import { EmbeddedEditorFile } from "@kie-tools-core/editor/dist/channel";
Expand Down
2 changes: 1 addition & 1 deletion examples/dmn-editor-on-webapp/src/Sidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import * as React from "react";
import { EditorEnvelopeLocator } from "@kie-tools-core/editor/dist/api";
import { useCallback, useRef, useState } from "react";
import { Nav, NavItem, NavList } from "@patternfly/react-core/dist/js/components/Nav";
import { Nav, NavList } from "@patternfly/react-core/dist/js/components/Nav";
import { TextInput } from "@patternfly/react-core/dist/js/components/TextInput";
import { EmbeddedEditorRef, useDirtyState } from "@kie-tools-core/editor/dist/embedded";
import { EmbeddedEditorFile } from "@kie-tools-core/editor/dist/channel";
Expand Down
8 changes: 4 additions & 4 deletions examples/dmn-editor-standalone-on-webapp/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ KIE_TOOLS_BUILD__buildExamples=true pnpm -F @kie-tools-examples/dmn-editor-stand
pnpm -F @kie-tools-examples/dmn-editor-standalone-on-webapp start
```

Open http://localhost:9102 to see the list of files bundled by Webpack, then choose an example:
Open http://localhost:7778 to see the list of files bundled by Webpack, then choose an example:

- State Control: http://localhost:9102/state_control.html
- Read Only: http://localhost:9102/read_only.html
- With Included Models: http://localhost:9102/with_included_models.html
- State Control: http://localhost:7778/state_control.html
- Read Only: http://localhost:7778/read_only.html
- With Included Models: http://localhost:7778/with_included_models.html

---

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ To make it easier to create `.base64png` files and exporting them to other forma
Before running this example, building its dependencies is required. Run the following command on a Terminal:

```shell script
KIE_TOOLS_BUILD__buildExamples=true pnpm -F @kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor-vscode-extension^... build:dev
KIE_TOOLS_BUILD__buildExamples=true pnpm -F kie-tools-examples-micro-frontends-multiplying-architecture-base64png-editor-vscode-extension^... build:dev
```

### Building
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ This package is a Custom Editor made with React, which enables you to edit a `.b

A `.base64png` file is a PNG image converted to base64 without its headers (e.g. data:image/png;base64).

To see it in action, refer to the [Base64 PNG Editor on Webapp](../micro-frontends-multiplying-architecture-base64png-editor-on-webapp/), the [Base64 PNG Editor VS Code Extension](../micro-frontends-multiplying-architecture-base64png-editor-vscode-extension/), or the [Base64 PNG Editor Chrome Extension](../micro-frontends-multiplying-architecture-base64png-editor-chrome-extension/) examples.

---

Apache KIE (incubating) is an effort undergoing incubation at The Apache Software
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

The Ping-Pong View is an interface that components can implement to be used inside a Ping-Pong View Envelope.

This package provides a library containing a Ping-Pong View implementation as a Angular application.
This package provides a library containing a Ping-Pong View implementation as a Angular application. To see it in action, refer to the [Ping-Pong Views on Webapp](../micro-frontends-multiplying-architecture-ping-pong-views-on-webapp/) example.

It's build into 3 projects:

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

The Ping-Pong View is an interface that components can implement to be used inside a Ping-Pong View Envelope.

Ths package provides a library containing a Ping-Pong View implementation as a React component.
Ths package provides a library containing a Ping-Pong View implementation as a React component. To see it in action, refer to the [Ping-Pong Views on Webapp](../micro-frontends-multiplying-architecture-ping-pong-views-on-webapp/) example.

---

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ This package provides a VS Code Extension containing a 'To do' List View, which
Before running this example, building its dependencies is required. Run the following command on a Terminal:

```shell script
KIE_TOOLS_BUILD__buildExamples=true pnpm -F @kie-tools-examples/micro-frontends-multiplying-architecture-todo-list-view-vscode-extension^... build:dev
KIE_TOOLS_BUILD__buildExamples=true pnpm -F kie-tools-examples-micro-frontends-multuplying-architecture-todo-list-view-vscode-extension^... build:dev
```

### Building
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ It's divided in the following directories:
1. `vscode`
- Provides a convenience class to create a Webview inside a VS Code Extension.

To see it in action, refer to the ['To do' List views on Webapp](../micro-frontends-multiplying-architecture-ping-pong-views-on-webapp/), or the ['To do' List VS Code Extension](../micro-frontends-multiplying-architecture-todo-list-view-vscode-extension/) examples.

---

Apache KIE (incubating) is an effort undergoing incubation at The Apache Software
Expand Down

0 comments on commit 71a1d57

Please sign in to comment.