Add locks to BundleWiringImpl. #341
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lack of locking in findClassOrResourceByDelegation and loadClass is causing race conditions that manifest as NoClassDefFoundError in a killbill deployment. This change works towards fixing these by adding synchronization.
hq6
force-pushed
the
hqin/fix_synchronization
branch
from
449729d
to
f55c38f
Compare
|
This PR will be easier to understand if you hide whitespace changes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lack of locking in findClassOrResourceByDelegation and loadClass is causing race conditions that manifest as
NoClassDefFoundErrorin a killbill deployment.This PR is intended to fix these by adding synchronization.