Fix panic when hashing empty FixedSizeList Array #13533
Conversation
Previously it would panic due to division by zero.
findepi
force-pushed
the
findepi/fix-panic-when-hashing-empty-fixedsizelist-array-ff5e68
branch
from
3ea432f
to
28e3b99
Compare
datafusion/common/src/hash_utils.rs
Outdated
| let offset_size = if array.len() == 0 { | ||
| 0 | ||
| } else { | ||
| value_len as usize / array.len() | ||
| }; |
There was a problem hiding this comment.
Would this be equiv to array.value_length()?
There was a problem hiding this comment.
I think value_length is different
Like a FixedSlizeLIst(3) would have elements that are each 3 bytes, but the array can have any number of elements (rows)
So in that case value_length() is 3
There was a problem hiding this comment.
in this example, value_length() is 3
array.len() is something, say N
so i though that value_len is 3 * N
ie. i kind of suspect this division is calculating what is know from the array type (the 3 in the example)
There was a problem hiding this comment.
🤔 https://docs.rs/arrow/latest/arrow/array/struct.FixedSizeBinaryArray.html#method.value_length
I don't understand what this offset_size is really used for to be honest -- it doesn't make a lot of sense below either
It seems the intention is more like offset_size = array.value_length() 🤔
There was a problem hiding this comment.
It seems the intention is more like
offset_size = array.value_length()🤔
that's my take too
datafusion/common/src/hash_utils.rs
Outdated
| let offset_size = if array.len() == 0 { | ||
| 0 | ||
| } else { | ||
| value_len as usize / array.len() | ||
| }; |
There was a problem hiding this comment.
I think value_length is different
Like a FixedSlizeLIst(3) would have elements that are each 3 bytes, but the array can have any number of elements (rows)
So in that case value_length() is 3
findepi
force-pushed
the
findepi/fix-panic-when-hashing-empty-fixedsizelist-array-ff5e68
branch
from
69136a2
to
4b46b8a
Compare
Previously it would panic due to division by zero.