refactor: use std::slice::from_ref to remove some clones
#13518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
comphead
approved these changes
Nov 21, 2024
alamb
approved these changes
Nov 21, 2024
| @@ -1671,7 +1671,7 @@ impl DataFrame { | |||
| /// # } | |||
| /// ``` | |||
| pub fn with_column(self, name: &str, expr: Expr) -> Result<DataFrame> { | |||
| let window_func_exprs = find_window_exprs(&[expr.clone()]); | |||
| let window_func_exprs = find_window_exprs(std::slice::from_ref(&expr)); | |||
There was a problem hiding this comment.
TIL https://doc.rust-lang.org/beta/std/slice/fn.from_ref.html -- very cool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Replace
&[T.clone()]withstd::slice::from_ref(&T)to avoid cloning of T.What changes are included in this PR?
Are these changes tested?
Yes. By existing tests.
Are there any user-facing changes?
No