Minor: add flags for temporary ddl #12561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
hailelagi
force-pushed
the
haile/add-flag-for-temporary-ddl
branch
from
0e03cba
to
a023c22
Compare
|
sorry, i took a bit longer than i was hoping with this one as i tried to get it to require minimal changes in the diff but as it is an api change i ended up spending quite a lot of time reading code. I have some questions and i'm super open to feedback, i'll self-review a few places where i was especially confused |
github-actions
bot
added
core
hailelagi
force-pushed
the
haile/add-flag-for-temporary-ddl
branch
from
a023c22
to
2cb1e93
Compare
hailelagi
commented
Sep 27, 2024
hailelagi
changed the title
jonahgao
reviewed
Sep 29, 2024
There was a problem hiding this comment.
Thanks @hailelagi . I think we should add some sqllogictest tests for this change. Perhaps in ddl.slt. In order to ensure the generation of correct logical plans, we can add tests similar to the following.
set datafusion.explain.logical_plan_only=true;
explain create temp table t(a int);
2cb1e93
to
7ac494c
Compare
jonahgao
reviewed
Oct 5, 2024
|
This PR seems to be failing CI and needs some more work, so marking it as a draft. When it is ready for another look, please mark it as ready for review |
hailelagi
force-pushed
the
haile/add-flag-for-temporary-ddl
branch
from
7ac494c
to
c909da2
Compare
hailelagi
force-pushed
the
haile/add-flag-for-temporary-ddl
branch
from
c909da2
to
5a82ff4
Compare
hailelagi
commented
Oct 12, 2024
Signed-off-by: Haile Lagi <[email protected]>
hailelagi
force-pushed
the
haile/add-flag-for-temporary-ddl
branch
from
5a82ff4
to
d955734
Compare
jonahgao
reviewed
Oct 12, 2024
Co-authored-by: Jonah Gao <[email protected]>
hailelagi
added a commit
to hailelagi/datafusion
that referenced
this pull request
Oct 14, 2024
* Minor: add flags for temporary ddl Signed-off-by: Haile Lagi <[email protected]> * Update datafusion/proto/src/logical_plan/mod.rs Co-authored-by: Jonah Gao <[email protected]> --------- Signed-off-by: Haile Lagi <[email protected]> Co-authored-by: Jonah Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12463
Rationale for this change
This introduces a new flag option
temporaryon theDdlStatementof:CreateMemoryTable,CreateExternalTableThese flags enable an implementation built on DF to define the semantics of a temporary table.
What changes are included in this PR?
Are these changes tested?
yes
Are there any user-facing changes?