Update concat_ws scalar function to support Utf8View #12309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Devan <[email protected]>
Signed-off-by: Devan <[email protected]>
|
Marking as draft as it looks like we are still working out the CI checks |
devanbenz
commented
Sep 5, 2024
Signed-off-by: Devan <[email protected]>
github-actions
bot
added
logical-expr
Signed-off-by: Devan <[email protected]>
Signed-off-by: Devan <[email protected]>
Signed-off-by: Devan <[email protected]>
Signed-off-by: Devan <[email protected]>
Signed-off-by: Devan <[email protected]>
Signed-off-by: Devan <[email protected]>
2010YOUY01
reviewed
Sep 9, 2024
| DataType::Utf8View => { | ||
| let string_array = as_string_view_array(array)?; | ||
|
|
||
| data_size += string_array.len(); |
There was a problem hiding this comment.
data_size is the estimated string array size after concatenation, I think here it should increment sum of inner buffers' size instead
(And everything else LGTM)
There was a problem hiding this comment.
Using data_size += string_array.data_buffers().len(); ?
disregard I think I get what you mean I modified it to sum up the inner buffer vec on each iteration and use that as the size
alamb
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Thank you @devanbenz -- this looks great to me
Thank you @2010YOUY01 for the review
| @@ -796,7 +796,7 @@ EXPLAIN SELECT | |||
| FROM test; | |||
| ---- | |||
| logical_plan | |||
| 01)Projection: concat_ws(Utf8(", "), CAST(test.column1_utf8view AS Utf8), CAST(test.column2_utf8view AS Utf8)) AS c | |||
| 01)Projection: concat_ws(Utf8(", "), test.column1_utf8view, test.column2_utf8view) AS c | |||
|
Thanks again @devanbenz and @2010YOUY01 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11837
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?