-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Android SDK 35 Support #1745
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1745 +/- ##
==========================================
- Coverage 72.50% 72.45% -0.06%
==========================================
Files 23 23
Lines 1837 1837
==========================================
- Hits 1332 1331 -1
- Misses 505 506 +1 ☔ View full report in Codecov by Sentry. |
The PR updates the version to 8.7.2 🤔 What about the kotlin version? should we update to 2.x? |
It seems I was using an RC version of Android Studio at the time that used AGP 8.7.0-rc01 as default. I’ve noticed a newer version and upgraded to the stable 8.7.2 but forgot to update the commit message, leading to incorrect information in the PR description. Since 8.7.2 is the current default, I’ll correct the commit message and update the PR description.
The latest official release of Android Studio is still using |
Kotlin 2 is considered beta for IDE users, so Android Studio might not behave as expected when using K2. https://kotlinlang.org/docs/releases.html#release-details So it might be better to stay on 1.x for now. |
Motivation and Context
Prepare for Cordova-Android 14 Release & Android SDK 35 support.
Description
Note: This PR is intended to collect changes for testing and will be split into smaller PRs later.
androidx.appcompat
to1.7.0
androidx.webkit
to1.12.1
com.google.gms:google-services
to4.4.2
kotlin-stdlib
to1.9.24
kotlin-stdlib-jdk7
andkotlin-stdlib-jdk8
from being installed by other libraries, askotlin-stdlib
is already included.require
statements to includenode:*
prefixes for Node.js internal modules.Testing
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)