Add parameter to not create additional users on cloudstack-setup-databases
#9969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "GRANT ALL ON cloud_usage.* to cloud@`localhost`;", | ||
| "GRANT ALL ON cloud_usage.* to cloud@`%`;", | ||
| "GRANT process ON *.* TO cloud@`localhost`;", | ||
| "GRANT process ON *.* TO cloud@`%`;", |
There was a problem hiding this comment.
last 2 queries are duplicates.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9969 +/- ##
============================================
- Coverage 15.80% 15.80% -0.01%
+ Complexity 12586 12585 -1
============================================
Files 5627 5627
Lines 492328 492343 +15
Branches 59692 59694 +2
============================================
- Hits 77828 77826 -2
- Misses 405977 405993 +16
- Partials 8523 8524 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the
cloudstack-setup-databasescommand during the database setup process, some additional users are created. Since the standard procedure involves creating and configuring database users prior to the ACS setup, these extra users are not used. Moreover, the additional users created bycloudstack-setup-databasesare granted excessive permissions, requiring operators to manually delete them.This PR introduces a new optional parameter,
--skip-users-auto-creation. By using this parameter, ACS will skip the automatic creation of these additional users.Types of changes
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
After executing the
cloudstack-setup-databaseswith the new flag, I checked the database users and, as expected, no new users were created. I then repeated the procedure without the new flag, and the extra users were created as usual.