-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packaging: support both mysql and mariadb on EL8/EL9 #9941
base: 4.19
Are you sure you want to change the base?
Conversation
@blueorangutan package |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9941 +/- ##
============================================
- Coverage 15.10% 15.10% -0.01%
+ Complexity 11225 11222 -3
============================================
Files 5404 5404
Lines 473502 473502
Branches 57733 57733
============================================
- Hits 71543 71533 -10
- Misses 393961 393974 +13
+ Partials 7998 7995 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11578 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should not be in centos7 spec file for 4.19, should it?
EL7 pkg is deprecated for main, for this is probably just for 4.19. |
[SF] Trillian Build Failed (tid-11786) |
[SF] Trillian Build Failed (tid-11785) |
this seems not working If mariadb is installed, dnf/yum still ask for mysql installation
|
cfab95c
to
00875e3
Compare
@blueorangutan package |
yes @DaanHoogland |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11586 |
tested ok in a rocky9 container |
[SF] Trillian Build Failed (tid-11789) |
[SF] Trillian Build Failed (tid-11790) |
[SF] Trillian Build Failed (tid-11792) |
[SF] Trillian test result (tid-11791)
|
[SF] Trillian Build Failed (tid-11800) |
[SF] Trillian Build Failed (tid-11805) |
[SF] Trillian Build Failed (tid-11804) |
[SF] Trillian test result (tid-11806)
|
[SF] Trillian test result (tid-11807)
|
Description
This PR fixes #9742
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?