Benchmark both scenarios, with records skipped and without skipping, for delta-bin-packed primitive arrays with half nulls. #6489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pped, for the delta-bin-packed primitive arrays
|
@etseidl -- lmk what you think. 🙏🏼 |
|
Ah, I understand now. Yes, this looks good to me. Makes me wonder why skip is only tested for binary packed. 🤔 |
alamb
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow up to this comment, when it was noticed that a certain benchmark scenario is not covered.
Rationale for this change
The delta-bin-packed primitive arrays, when half null, was not benchmarked for both skipping and no skipped record batches. This is a minor change to include both scenarios.
What changes are included in this PR?
See above.
Are there any user-facing changes?
No