Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIP-84 Get Task Instance Tries #44301

Merged
merged 7 commits into from
Nov 25, 2024
Merged

AIP-84 Get Task Instance Tries #44301

merged 7 commits into from
Nov 25, 2024

Conversation

kandharvishnu
Copy link
Contributor

related to: #42370

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 23, 2024
@rawwar rawwar added the legacy api Whether legacy API changes should be allowed in PR label Nov 23, 2024
pierrejeambrun
pierrejeambrun reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Just a few suggestions.

airflow/api_fastapi/core_api/routes/public/task_instances.py Outdated Show resolved Hide resolved
tests/api_fastapi/core_api/routes/public/test_task_instances.py Show resolved Hide resolved
@pierrejeambrun pierrejeambrun mentioned this pull request Nov 25, 2024
Open
1 task
pierrejeambrun
pierrejeambrun approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge, thanks.

@pierrejeambrun
Copy link
Member

Rebasing again, need latest main fix for the CI.

@pierrejeambrun pierrejeambrun merged commit 19e97da into apache:main Nov 25, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@jscheffl jscheffl Awaiting requested review from jscheffl jscheffl is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

@rawwar rawwar Awaiting requested review from rawwar

Assignees
No one assigned
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kandharvishnu @pierrejeambrun @rawwar