Rename CLI flag that specifies execution date #44282
Draft
+26
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'airflow dags trigger' command takes -e and --exec-date referring to the legacy "execution date" name. New -l and --logical-date flags have been added to refer to the new "logical date" name. A custom argument action is implemented to emit a deprecation message when either -e or --exec-date is used instead of the new flags. Note that we do not use warnings.warn() here, but emit a message directly to stderr, because this is intended to be fired by a CLI call, which does not want the call stack provided by warnings.warn(). This is also what argparse does when you use the new 'deprecated' option on an argument (new in Python 3.13).
|
Actually, we might want to remove this argument entirely instead, and prefer data interval fields. Converting this to draft for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'airflow dags trigger' command takes -e and --exec-date referring to the legacy "execution date" name. New -l and --logical-date flags have been added to refer to the new "logical date" name.
A custom argument action is implemented to emit a deprecation message when either -e or --exec-date is used instead of the new flags. Note that we do not use warnings.warn() here, but emit a message directly to stderr, because this is intended to be fired by a CLI call, which does not want the call stack provided by warnings.warn(). This is also what argparse does when you use the new 'deprecated' option on an argument (new in Python 3.13).