fixes multiple upgrade bugs found when testing #4717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug where upgrade code was attemptnig to read the managers service lock before it was set. Fixed a bug with deteting fate operations. The code to detect fate operations would hang trying to read the fate table which did not exists yet. Scans of the metadata table running as the !SYSTEM user would fail if no auths were specified. The !SYSTEM user has not auths set in zookeeper and an exception would happen when trying to find them. A new zookeeper node related to compaction changes needed to be created. Simplified code for setting tablet availability by using DataLevel.
dlmarion
approved these changes
Jul 2, 2024
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/UpgradeCoordinator.java
Outdated
Show resolved
Hide resolved
kevinrr888
reviewed
Jul 2, 2024
| // as not tablets are assigned when this is called. The Fate code is not used to read from | ||
| // zookeeper below because the serialization format changed in zookeeper, that is why a direct | ||
| // read is performed. | ||
| if (!context.getZooReader().getChildren(context.getZooKeeperRoot() + Constants.ZFATE) |
There was a problem hiding this comment.
Ah was briefly looking over this and was wondering why it was only looking at ZK... This makes sense good catch. Haven't looked at the other classes but the changes for this class LGTM
There was a problem hiding this comment.
The upgrade from 4.0 to 4.1 will probably need to look at the new fate table, which will be tricky. Will open an issue for that now so its not forgotten.
…de/UpgradeCoordinator.java Co-authored-by: Dave Marion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where upgrade code was attemptnig to read the managers service lock before it was set.
Fixed a bug with deteting fate operations. The code to detect fate operations would hang trying to read the fate table which did not exists yet.
Scans of the metadata table running as the !SYSTEM user would fail if no auths were specified. The !SYSTEM user has not auths set in zookeeper and an exception would happen when trying to find them.
A new zookeeper node related to compaction changes needed to be created.
Simplified code for setting tablet availability by using DataLevel.