Update README.md to include a hint for WSL #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a little bit of text which hints WSL users to run `cargo install spotify_player` with `--locked` so it'll work.
aome510
requested changes
Oct 9, 2024
There was a problem hiding this comment.
This error is not specific to wsl. It's better to update https://github.com/aome510/spotify-player?tab=readme-ov-file#cargo to include --locked instead and add a note saying that --locked is important for cargo to use the packaged Cargo.lock file
changed the whole cargo install section instead of adding a note for WSL as requested
|
(I rarely work with github, I hope I did not press any annoying buttons, If I did, I'm very sorry) |
aome510
approved these changes
Oct 9, 2024
all good, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a little bit of text which hints WSL users to run
cargo install spotify_playerwith--lockedso it'll work.This should avoid further issues being created to find this solution.