Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 调整暗黑主题样式的加载方式, 避免样式污染和构建错误 #2988

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

lijinke666
Copy link
Member

👀 PR includes

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

📝 Description

🖼️ Screenshot

Before After

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Nov 26, 2024 8:31am

@github-actions github-actions bot added the pr(refactor) refactor label Nov 26, 2024
@github-actions github-actions bot added the next 2.0-next 版本的问题 label Nov 26, 2024
Copy link
Contributor

github-actions bot commented Nov 26, 2024

Size Change: +452 B (+0.07%)

Total Size: 618 kB

Filename Size Change
./packages/s2-core/dist/s2.min.css 581 B +193 B (+49.74%) 🆘
./packages/s2-core/dist/s2.min.js 256 kB -102 B (-0.04%)
./packages/s2-react/dist/s2-react.min.css 1.74 kB +190 B (+12.25%) ⚠️
./packages/s2-react/dist/s2-react.min.js 38.3 kB -32 B (-0.08%)
./packages/s2-vue/dist/s2-vue.min.css 2.05 kB +203 B (+10.99%) ⚠️
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/s2-extends.min.js 153 kB
./packages/s2-react-components/dist/s2-react-components.min.css 2.55 kB
./packages/s2-react-components/dist/s2-react-components.min.js 125 kB
./packages/s2-vue/dist/s2-vue.min.js 38.2 kB

compressed-size-action

Copy link
Contributor

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Nov 26, 2024
@lijinke666 lijinke666 merged commit fa142fa into next Nov 26, 2024
7 of 9 checks passed
@lijinke666 lijinke666 deleted the fix-dark-them branch November 26, 2024 09:33
@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Nov 26, 2024
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v2.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(refactor) refactor released on @latest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants