Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 优化紧凑模式下的单元格宽度计算方式 #2953

Merged
merged 5 commits into from
Nov 1, 2024

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Oct 30, 2024

👀 PR includes

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

📝 Description

  1. 对测量的文本宽度向上取整, 避免紧凑模式下极端情况出现文本出现省略号的问题
  2. 调整单元格最小可拖拽宽度的默认值 🐛紧凑模式,手动拖拽减小列宽,字体直接溢出 #2900

🖼️ Screenshot

Before After

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Nov 1, 2024 10:21am

@github-actions github-actions bot added pr(feature) new feature next 2.0-next 版本的问题 labels Oct 30, 2024
Copy link
Contributor

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 lint failed 静态检查失败 label Oct 30, 2024
Copy link
Contributor

github-actions bot commented Oct 30, 2024

Size Change: +15 B (0%)

Total Size: 335 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 236 kB +15 B (+0.01%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 388 B
./packages/s2-react/dist/index.min.js 70.9 kB
./packages/s2-react/dist/style.min.css 3.77 kB
./packages/s2-vue/dist/index.min.js 22.9 kB
./packages/s2-vue/dist/style.min.css 1.85 kB

compressed-size-action

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.70%. Comparing base (ecdc9c8) to head (edf0b94).
Report is 469 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2953      +/-   ##
==========================================
+ Coverage   75.77%   80.70%   +4.93%     
==========================================
  Files         257      179      -78     
  Lines       11994    10426    -1568     
  Branches     2464     2371      -93     
==========================================
- Hits         9088     8414     -674     
+ Misses       1398      561     -837     
+ Partials     1508     1451      -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lijinke666 lijinke666 merged commit 68ed225 into next Nov 1, 2024
8 of 9 checks passed
@lijinke666 lijinke666 deleted the feat-optimize-compact branch November 1, 2024 10:35
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.31 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v2.0.0-next.30 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(feature) new feature released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants