Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复字段标记 mapping 函数部分场景缺失第三个参数 & 调整参数类型 #2927

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Oct 15, 2024

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

  • Solve the issue and close #0

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

🖼️ Screenshot

Before After

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Oct 15, 2024 3:51am

@github-actions github-actions bot added the pr(fix) bug fix label Oct 15, 2024
@github-actions github-actions bot added the next 2.0-next 版本的问题 label Oct 15, 2024
Copy link
Contributor

Size Change: +23 B (+0.01%)

Total Size: 329 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 229 kB +23 B (+0.01%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 388 B
./packages/s2-react/dist/index.min.js 70.9 kB
./packages/s2-react/dist/style.min.css 3.88 kB
./packages/s2-vue/dist/index.min.js 22.9 kB
./packages/s2-vue/dist/style.min.css 1.97 kB

compressed-size-action

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.81%. Comparing base (ecdc9c8) to head (383b879).
Report is 450 commits behind head on next.

Files with missing lines Patch % Lines
packages/s2-core/src/utils/text.ts 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2927      +/-   ##
==========================================
+ Coverage   75.77%   80.81%   +5.04%     
==========================================
  Files         257      180      -77     
  Lines       11994    10425    -1569     
  Branches     2464     2364     -100     
==========================================
- Hits         9088     8425     -663     
+ Misses       1398      554     -844     
+ Partials     1508     1446      -62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjgogogo wjgogogo merged commit 676c1f6 into next Oct 17, 2024
16 of 17 checks passed
@wjgogogo wjgogogo deleted the fix-condition-type branch October 17, 2024 02:05
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.30 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants