Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复自定义 dataCell 错误的传参写法 #2748

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented May 28, 2024

👀 PR includes

🐛 Bugfix

  • Solve the issue and close #0

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

const s2Options = {
   width: 600,
-  dataCell: (viewMeta) => {
-    return new CustomDataCell(viewMeta, viewMeta.spreadsheet);
-  }
+  dataCell: (viewMeta, spreadsheet) => {
+    return new CustomDataCell(viewMeta, spreadsheet);
+  }
}

🖼️ Screenshot

Before After

🔗 Related issue link

#2747

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@github-actions github-actions bot added the pr(fix) bug fix label May 28, 2024
Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) May 28, 2024 9:55am

@github-actions github-actions bot added the next 2.0-next 版本的问题 label May 28, 2024
Copy link
Contributor

Size Change: -7 B (0%)

Total Size: 324 kB

Filename Size Change
./packages/s2-react/dist/index.min.js 69.4 kB -7 B (-0.01%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/index.min.js 227 kB
./packages/s2-core/dist/style.min.css 402 B
./packages/s2-react/dist/style.min.css 3.92 kB
./packages/s2-vue/dist/index.min.js 21 kB
./packages/s2-vue/dist/style.min.css 1.99 kB

compressed-size-action

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.98%. Comparing base (ecdc9c8) to head (90566b6).
Report is 369 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2748      +/-   ##
==========================================
+ Coverage   75.77%   79.98%   +4.21%     
==========================================
  Files         257      176      -81     
  Lines       11994    10167    -1827     
  Branches     2464     2330     -134     
==========================================
- Hits         9088     8132     -956     
+ Misses       1398      616     -782     
+ Partials     1508     1419      -89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjgogogo wjgogogo merged commit c54ca82 into next May 31, 2024
14 of 15 checks passed
@wjgogogo wjgogogo deleted the docs-data-cell branch May 31, 2024 10:06
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v2.0.0-next.22 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants