Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复下载数据重复 close #2718 #2719

Merged
merged 5 commits into from
May 14, 2024

Conversation

wyh888
Copy link
Contributor

@wyh888 wyh888 commented May 13, 2024

👀 PR includes

🐛 Bugfix

📝 Description

背景

当复制/导出数据大于1w条时,会出现重复数据:

image image

🖼️ Screenshot

Before After
image image

🔗 Related issue link

close #2718

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) May 14, 2024 8:46am

@lijinke666
Copy link
Member

感谢贡献, 请补充一个相应单测 packages/s2-core/tests/unit/utils/export/export-table-spec.ts (数据量大可以判断下 data.length, 不需要比对快照)

@wyh888
Copy link
Contributor Author

wyh888 commented May 13, 2024

感谢贡献, 请补充一个相应单测 packages/s2-core/tests/unit/utils/export/export-table-spec.ts (数据量大可以判断下 data.length, 不需要比对快照)

已提交,请查阅

@lijinke666
Copy link
Member

🐂🍺

@lijinke666 lijinke666 merged commit f0d5192 into antvis:next May 14, 2024
8 of 9 checks passed
@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-v2.0.0-next.21 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants