Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复表格右键事件无法触发 close #2687 #2690

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

lijinke666
Copy link
Member

👀 PR includes

🐛 Bugfix

📝 Description

  1. G 的右键事件对应 rightup/rightdown, G 的 rightup 有 bug, 有时候不能触发, 修改为 rightdown
  2. 增加如何禁用右键默认菜单的文档, G 相关文档: https://g.antv.antgroup.com/api/event/faq#%E7%A6%81%E7%94%A8%E5%8F%B3%E9%94%AE%E8%8F%9C%E5%8D%95

🖼️ Screenshot

Before After

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Apr 29, 2024 3:05am

@github-actions github-actions bot added the next 2.0-next 版本的问题 label Apr 29, 2024
@github-actions github-actions bot added the pr(fix) bug fix label Apr 29, 2024
@lijinke666 lijinke666 linked an issue Apr 29, 2024 that may be closed by this pull request
5 tasks
Copy link
Contributor

Size Change: -3 B (0%)

Total Size: 320 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 223 kB -3 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 402 B
./packages/s2-react/dist/index.min.js 69.3 kB
./packages/s2-react/dist/style.min.css 4 kB
./packages/s2-vue/dist/index.min.js 21 kB
./packages/s2-vue/dist/style.min.css 1.97 kB

compressed-size-action

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.10%. Comparing base (ecdc9c8) to head (9e408b8).
Report is 327 commits behind head on next.

Files Patch % Lines
...ckages/s2-core/src/interaction/event-controller.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2690      +/-   ##
==========================================
+ Coverage   75.77%   80.10%   +4.33%     
==========================================
  Files         257      176      -81     
  Lines       11994    10073    -1921     
  Branches     2464     2304     -160     
==========================================
- Hits         9088     8069    -1019     
+ Misses       1398      618     -780     
+ Partials     1508     1386     -122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lijinke666 lijinke666 merged commit 8b4f3e3 into next Apr 30, 2024
12 of 13 checks passed
@lijinke666 lijinke666 deleted the fix-2687 branch April 30, 2024 02:00
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.19 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v2.0.0-next.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛S2Event.GLOBAL_CONTEXT_MENU 事件无法触发
2 participants