Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复只有一行数据时异步导出数据为空 close #2681 #2682

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

lijinke666
Copy link
Member

👀 PR includes

🐛 Bugfix

📝 Description

调整异步导出 requestIdleCallback 的计算逻辑, 兼容只有一行数据的导出链路.

🖼️ Screenshot

Before After
image image

🔗 Related issue link

close #2681

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Apr 25, 2024 7:41am

@lijinke666 lijinke666 linked an issue Apr 25, 2024 that may be closed by this pull request
5 tasks
@github-actions github-actions bot added the next 2.0-next 版本的问题 label Apr 25, 2024
@github-actions github-actions bot added the pr(fix) bug fix label Apr 25, 2024
Copy link
Contributor

Size Change: +15 B (0%)

Total Size: 319 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 223 kB +15 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 402 B
./packages/s2-react/dist/index.min.js 69.3 kB
./packages/s2-react/dist/style.min.css 4 kB
./packages/s2-vue/dist/index.min.js 20.3 kB
./packages/s2-vue/dist/style.min.css 1.97 kB

compressed-size-action

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 79.04%. Comparing base (ecdc9c8) to head (06d358a).
Report is 309 commits behind head on next.

Files Patch % Lines
...core/src/utils/export/copy/pivot-data-cell-copy.ts 60.00% 2 Missing ⚠️
...ckages/s2-core/src/utils/export/copy/table-copy.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2682      +/-   ##
==========================================
+ Coverage   75.77%   79.04%   +3.27%     
==========================================
  Files         257      274      +17     
  Lines       11994    12415     +421     
  Branches     2464     2544      +80     
==========================================
+ Hits         9088     9813     +725     
+ Misses       1398     1063     -335     
- Partials     1508     1539      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lijinke666 lijinke666 merged commit fecd455 into next Apr 26, 2024
8 of 9 checks passed
@lijinke666 lijinke666 deleted the fix-2681 branch April 26, 2024 03:21
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛[NEXT] 表格导出当只row有一行时返回空数据
3 participants