fix(interaction): 修复在未选中状态下调整宽高, 错误的修改了相邻单元格的样式 #2605
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -292,22 +292,25 @@ export class RowColumnResize extends BaseEvent implements BaseEventImplement { | |||
| const { interaction } = this.spreadsheet; | |||
| const resizeInfo = this.getResizeInfo(); | |||
|
|
|||
| const isVertical = resizeInfo.type === ResizeDirectionType.Vertical; | |||
| const activeCells = isVertical | |||
| ? interaction.getActiveRowCells() | |||
There was a problem hiding this comment.
如果鼠标刚好 hover 到相邻的列头上, activeColCells 此时是它, 所以会更新错误, 对于单选和非选中场景, 都走默认逻辑
|
Size Change: +18 B (0%) Total Size: 318 kB
ℹ️ View Unchanged
|
|
你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。 Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2605 +/- ##
==========================================
+ Coverage 75.77% 78.98% +3.21%
==========================================
Files 257 274 +17
Lines 11994 12387 +393
Branches 2464 2526 +62
==========================================
+ Hits 9088 9784 +696
+ Misses 1398 1067 -331
- Partials 1508 1536 +28 ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version @antv/s2-v2.0.0-next.16 🎉 The release is available on: Your semantic-release bot 📦🚀 |
👀 PR includes
🐛 Bugfix
📝 Description
修复在 https://github.com/antvis/S2/pull/2580/files#diff-25f297d6f5ede47828d6ddfcee924d9b9a7d7f3f46741bcba9cf96ed0d4973aeR297-R298 支持批量调整单元格样式后, 引入的一个 bug : 调整第一列, 但会更新第二列的单元格.
🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge