Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 增加角头和序号列的交互能力 #2571

Merged
merged 13 commits into from
Mar 8, 2024

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Mar 1, 2024

👀 PR includes

✨ Feature

  • New feature

🐛 Bugfix

📝 Description

  1. 新增行角头的交互能力: 现在点击行角头, 会选中对应的列头. close 🙏 透视表支持点击角头(列)字段时,选中相应行 #2480
Before After
image image
  1. 新增序号角头的交互能力: 现在点击序号角头, 选选中当前列
Before After
image image
  1. 序号列支持 hover 高亮, 和其他单元格保持体验一致
Before After
image image
  1. 数值单元格行列十字高亮, 现在会包含序号单元格
Before After
image image
image image
  1. 修复透视表树状模式下, 全部展开收起 icon 渲染位置错误的问题 close 透视表树结构展开按钮不能正确的渲染 #2563
Before After
image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Mar 8, 2024 9:44am

@github-actions github-actions bot added next 2.0-next 版本的问题 pr(feature) new feature labels Mar 1, 2024
Copy link
Contributor

github-actions bot commented Mar 1, 2024

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Mar 1, 2024
Copy link
Contributor

github-actions bot commented Mar 1, 2024

Size Change: +909 B (0%)

Total Size: 318 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 222 kB +270 B (0%)
./packages/s2-react/dist/index.min.js 69.3 kB +586 B (+1%)
./packages/s2-react/dist/style.min.css 4 kB -12 B (0%)
./packages/s2-vue/dist/index.min.js 20.3 kB +77 B (0%)
./packages/s2-vue/dist/style.min.css 1.97 kB -12 B (-1%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 402 B

compressed-size-action

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 89.06250% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 78.87%. Comparing base (ecdc9c8) to head (96f2eb0).
Report is 270 commits behind head on next.

Files Patch % Lines
...action/base-interaction/click/corner-cell-click.ts 86.95% 0 Missing and 3 partials ⚠️
.../s2-core/src/interaction/base-interaction/hover.ts 71.42% 2 Missing ⚠️
packages/s2-core/src/cell/data-cell.ts 85.71% 1 Missing ⚠️
packages/s2-core/src/cell/series-number-cell.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2571      +/-   ##
==========================================
+ Coverage   75.77%   78.87%   +3.10%     
==========================================
  Files         257      274      +17     
  Lines       11994    12367     +373     
  Branches     2464     2521      +57     
==========================================
+ Hits         9088     9755     +667     
+ Misses       1398     1079     -319     
- Partials     1508     1533      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lijinke666 lijinke666 changed the title feat: 增加角头和序号列的交互能力 [WIP] feat: 增加角头和序号列的交互能力 Mar 8, 2024
@github-actions github-actions bot removed the pr(feature) new feature label Mar 8, 2024
@lijinke666 lijinke666 changed the title [WIP] feat: 增加角头和序号列的交互能力 feat: 增加角头和序号列的交互能力 Mar 8, 2024
@github-actions github-actions bot added the pr(feature) new feature label Mar 8, 2024
@lijinke666 lijinke666 merged commit fcb77cc into next Mar 8, 2024
7 of 8 checks passed
@lijinke666 lijinke666 deleted the feat-enhance-interaction branch March 8, 2024 09:41
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v2.0.0-next.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(feature) new feature released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants