refactor: 函数命名getCrossBackgroundColor、测试用例使用createPivotSheet

antvis · Sep 8, 2023 · cc9ac56 · cc9ac56
1 parent 63db80b
commit cc9ac56
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 11 deletions.
diff --git a/packages/s2-core/__tests__/unit/cell/row-cell-spec.ts b/packages/s2-core/__tests__/unit/cell/row-cell-spec.ts
@@ -1,8 +1,6 @@
 import { get } from 'lodash';
-import { createPivotSheet, getContainer } from 'tests/util/helpers';
+import { createPivotSheet } from 'tests/util/helpers';
 import type { RowCell } from '@antv/s2';
-import simpleData from '../../data/simple-data.json';
-import { PivotSheet } from '@/index';
 import type { SpreadSheet } from '@/sheet-type';
 import type { TextAlign } from '@/common';
 
@@ -117,7 +115,7 @@ describe('Row Cell Tests', () => {
   });
 
   describe('Cross Background Color Tests', () => {
-    const s2 = new PivotSheet(getContainer(), simpleData, {
+    const s2 = createPivotSheet({
       width: 800,
       height: 600,
     });

diff --git a/packages/s2-core/src/cell/base-cell.ts b/packages/s2-core/src/cell/base-cell.ts
@@ -463,17 +463,19 @@ export abstract class BaseCell<T extends SimpleBBox> extends Group {
     return fillResult;
   }
 
-  protected getBackgroundColorByCross(rowIndex: number) {
+  protected getCrossBackgroundColor(rowIndex: number) {
     const { crossBackgroundColor, backgroundColorOpacity } =
       this.getStyle().cell;
 
-    let backgroundColor = this.getStyle().cell.backgroundColor;
-
     if (crossBackgroundColor && rowIndex % 2 === 0) {
       // 隔行颜色的配置
       // 偶数行展示灰色背景，因为index是从0开始的
-      backgroundColor = crossBackgroundColor;
+      return { backgroundColorOpacity, backgroundColor: crossBackgroundColor };
     }
-    return { backgroundColorOpacity, backgroundColor };
+
+    return {
+      backgroundColorOpacity,
+      backgroundColor: this.getStyle().cell.backgroundColor,
+    };
   }
 }
diff --git a/packages/s2-core/src/cell/data-cell.ts b/packages/s2-core/src/cell/data-cell.ts
@@ -308,7 +308,7 @@ export class DataCell extends BaseCell<ViewMeta> {
   }
 
   public getBackgroundColor() {
-    const backgroundColorByCross = this.getBackgroundColorByCross(
+    const backgroundColorByCross = this.getCrossBackgroundColor(
       this.meta.rowIndex,
     );
     let backgroundColor = backgroundColorByCross.backgroundColor;

diff --git a/packages/s2-core/src/cell/row-cell.ts b/packages/s2-core/src/cell/row-cell.ts
@@ -72,7 +72,7 @@ export class RowCell extends HeaderCell {
 
   public getBackgroundColor() {
     const { backgroundColor, backgroundColorOpacity } =
-      this.getBackgroundColorByCross(this.meta.rowIndex);
+      this.getCrossBackgroundColor(this.meta.rowIndex);
     return this.getBackgroundColorByCondition(
       backgroundColor,
       backgroundColorOpacity,