Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move @ctrl/tinycolor out of dependencies #231

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 24, 2024

Summary by CodeRabbit

  • 文档
    • 更新了package.json文件,调整了@ctrl/tinycolor的依赖项,将其从运行时依赖移至开发依赖。

Copy link
Contributor

coderabbitai bot commented Nov 24, 2024

📝 Walkthrough

Walkthrough

此次更改主要涉及package.json文件,具体是将@ctrl/tinycolor依赖项从dependencies部分移至devDependencies部分。这一调整表明该依赖项不再是运行时依赖,而是仅在开发过程中使用。版本约束保持不变,仍为^4.1.0。该更改未影响其他依赖项、脚本或配置。

Changes

文件 更改摘要
package.json @ctrl/tinycolordependencies移至devDependencies,版本保持^4.1.0

Possibly related PRs

兔子欢跃在草地,
依赖变动乐无比。
从依赖到开发,
轻松自在无烦恼。
小小变化大不同,
代码清晰更轻松! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Nov 24, 2024

Preview is ready

Copy link

codecov bot commented Nov 24, 2024

Bundle Report

Bundle size has no change ✅

Copy link

Deploying ant-design-x with  Cloudflare Pages  Cloudflare Pages

Latest commit: 32bafbe
Status: ✅  Deploy successful!
Preview URL: https://4162ebb2.ant-design-x.pages.dev
Branch Preview URL: https://chore--ctrl-tinycolor.ant-design-x.pages.dev

View logs

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between f3e7883 and 32bafbe.

📒 Files selected for processing (1)
  • package.json (1 hunks)
🔇 Additional comments (1)
package.json (1)

103-103: 验证依赖项的移除

请确认 @ctrl/tinycolor 已从 dependencies 部分完全移除,以避免重复声明。

✅ Verification successful

@ctrl/tinycolor 依赖项声明正常

根据验证结果,@ctrl/tinycolor 在 package.json 中只有一处声明,位于 dependencies 中,版本为 ^4.1.0。没有发现重复声明的问题。

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 描述:验证 @ctrl/tinycolor 是否已从 dependencies 中移除

# 检查 package.json 中的 dependencies
echo "检查 dependencies 中是否还存在 @ctrl/tinycolor..."
rg "\"@ctrl/tinycolor\"" package.json

Length of output: 163


Script:

#!/bin/bash
# 检查 package.json 中是否存在重复的 @ctrl/tinycolor 声明
echo "检查 package.json 的完整内容..."
cat package.json | jq '.dependencies, .devDependencies' | rg "@ctrl/tinycolor"

Length of output: 168

package.json Show resolved Hide resolved
Copy link

size-limit report 📦

Path Size
dist/antdx.min.js 45.72 KB

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.13%. Comparing base (f3e7883) to head (32bafbe).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage   91.13%   91.13%           
=======================================
  Files          66       66           
  Lines        1421     1421           
  Branches      364      364           
=======================================
  Hits         1295     1295           
  Misses        126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@YumoImer
Copy link
Collaborator

image

全局检索了下,站点在使用,删了可能会导致使用 pnpm 无法启动项目进行调试。

@afc163
Copy link
Member Author

afc163 commented Nov 24, 2024

没有删,移到 devDeps 里了。

Copy link
Collaborator

@YumoImer YumoImer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@YumoImer YumoImer merged commit ec995fa into main Nov 24, 2024
16 checks passed
@YumoImer YumoImer deleted the chore/@ctrl/tinycolor branch November 24, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants